Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove namespace as a package parameter #43

Closed
jlewi opened this issue Dec 20, 2017 · 1 comment
Closed

Remove namespace as a package parameter #43

jlewi opened this issue Dec 20, 2017 · 1 comment
Assignees
@ankushagarwal
Labels
priority/p2

Comments

@jlewi
Copy link
Contributor

jlewi commented Dec 20, 2017

Most of our ksonnet packages have namespace as an explicit parameter.

This is a work around for ksonnet/ksonnet#222. Once that's fixed and components can inherit namespace from the environment we can remove namespace as an explicit parameter.
@ankushagarwal ankushagarwal self-assigned this Mar 14, 2018
@ankushagarwal
Copy link
Contributor

We should be unblocked on this since ksonnet/ksonnet#222 has closed

@ankushagarwal ankushagarwal mentioned this issue Mar 14, 2018
Merged
k8s-ci-robot pushed a commit that referenced this issue Mar 20, 2018
@k8s-ci-robot
Inherit namespace from ksonnet environment (#426)
8d617d6 
* Inherit namespace from ksonnet environment

Now that ksonnet makes `env` available in it's components, we can
leverate that to use the environment's namespace instead of hardcoding a
default namespace in the component parameters.

So now the behaviour is that when components are generated from
prototypes, we default to using the environment's namespace. If the user
has overridden namespace as a parameter, that will get used for the
component.

Tested by deploying kubeflow-core and tf-serving to a new k8s cluster

Fixes #43

* Re-introduce namespace parameter in components because removing it will
break existing clients

* Update mlkube-testing image to kubeflow-ci image

* Revert components/k8s-model-server/images/releaser/components/workflows.libsonnet

* Update mlkube-testing to kubeflow-ci

* Undo changes to releasing files as they are unrelated

* Update jupyterhub.libsonnet comment

* Set imagePullPolicy to always

* Print ks version

* Update tfserving test to use kubeflow-ci/test-worker
@ankushagarwal ankushagarwal mentioned this issue Mar 20, 2018
Merged
k8s-ci-robot pushed a commit that referenced this issue Mar 20, 2018
@k8s-ci-robot
Update cert-manager component to inherit namespace (#466)
8367add 
Related to #43
@ankushagarwal ankushagarwal mentioned this issue Mar 20, 2018
Merged
kimwnasptd pushed a commit to arrikto/kubeflow that referenced this issue Mar 5, 2019
@jlewi @k8s-ci-robot
Fix the GitHub org membership. (kubeflow#43)
c404f51 
@zhenghuiwang needs to be added to members not just team.

@siejiemoy is currently a member but not in the YAML file (He's part of Google's
UX team for Kubeflow).
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Nov 1, 2019
@gabrielwen @k8s-ci-robot
Pipeline UI ISTIO manifests (kubeflow#43)
a3de5b8 
* updates

* link

* updates

* add params

* add resource
maroroman pushed a commit to maroroman/kubeflow that referenced this issue Dec 19, 2022
@openshift-merge-robot
Merge pull request kubeflow#43 from VaishnaviHire/rhods_5811
d46512c 
Add Support for Cluster Proxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankushagarwal ankushagarwal

Labels
priority/p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlewi @ankushagarwal