Profile controller not using camel case for resourcequotaspec and GcpServiceAccount

[jlewi]

/kind bug

Here is the profile created by default on gcp

kubectl -n kubeflow get profiles -o yaml
apiVersion: v1
items:
- apiVersion: kubeflow.org/v1beta1
  kind: Profile
  metadata:
    annotations:
      kubectl.kubernetes.io/last-applied-configuration: |
        {"apiVersion":"kubeflow.org/v1beta1","kind":"Profile","metadata":{"annotations":{},"name":"kubeflow-jlewi"},"spec":{"owner":{"kind":"User","name":"jlewi@google.com"}}}
    creationTimestamp: "2019-10-24T03:55:37Z"
    finalizers:
    - profile-finalizer
    generation: 2
    name: kubeflow-jlewi
    resourceVersion: "5648"
    selfLink: /apis/kubeflow.org/v1beta1/profiles/kubeflow-jlewi
    uid: 232bf931-f612-11e9-8cd6-42010a8e012b
  spec:
    owner:
      kind: User
      name: jlewi@google.com
    plugins:
    - kind: WorkloadIdentity
      spec:
        GcpServiceAccount: kftest-1023-204737-user@jlewi-dev.iam.gserviceaccount.com
    resourcequotaspec: {}

The names of the plugins field spec.GcpServiceAccount and resourcequotaspec do not follow standard Kubernetes camel case.

The convention is

gcpServiceAccount
resourceQuotaSpec

This code

kubeflow/components/profile-controller/controllers/plugin_workload_identity.go

Line 40 in d6459f4

GcpServiceAccount string `json:"gcpserviceaccount,omitempty"`

Leads me to expect it would be gcpserviceaccount

It looks like resourcequotaspec is set incorrectly here

kubeflow/components/profile-controller/api/v1beta1/profile_types.go

Line 43 in 529de7d

ResourceQuotaSpec v1.ResourceQuotaSpec `json:"resourcequotaspec,omitempty"`

P0 because this is an API change and we want the API to not have to change after v1beta1.

[issue-label-bot]

Issue-Label Bot is automatically applying the label kind/bug to this issue, with a confidence of 0.97. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[lluunn]

I don't understand with json:"gcpserviceaccount,omitempty" why it's showing GcpServiceAccount?

[jlewi]

@kunmingg just submitted a fix
#4396

We need to cherry pick it onto the branch.

[jlewi]

Verified this is fixed using

kubeflow/manifests - v0.7.0-rc.2-16-gd6dad08
kubeflow/kubeflow - v0.4.0-rc.1-802-gd66f8b97

kubectl -n kubeflow get profiles -o yaml
apiVersion: v1
items:
- apiVersion: kubeflow.org/v1beta1
  kind: Profile
  metadata:
    annotations:
      kubectl.kubernetes.io/last-applied-configuration: |
        {"apiVersion":"kubeflow.org/v1beta1","kind":"Profile","metadata":{"annotations":{},"name":"kubeflow-jlewi"},"spec":{"owner":{"kind":"User","name":"jlewi@google.com"}}}
    creationTimestamp: "2019-10-31T00:13:47Z"
    finalizers:
    - profile-finalizer
    generation: 2
    name: kubeflow-jlewi
    resourceVersion: "5343"
    selfLink: /apis/kubeflow.org/v1beta1/profiles/kubeflow-jlewi
    uid: 4f1bfd8e-fb73-11e9-a86e-42010a8e001c
  spec:
    owner:
      kind: User
      name: jlewi@google.com
    plugins:
    - kind: WorkloadIdentity
      spec:
        gcpServiceAccount: kftest-1030-170357-user@jlewi-dev.iam.gserviceaccount.com
    resourceQuotaSpec: {}
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""