tf-cnn fails to create

[hyperbolic2346]

I'm not sure if this is a kubeflow issue or a ksonnet one, but when I try to follow the directions on tf-cnn from here I get the following error:

 knobby  ~/kubeflow  ks generate tf-cnn mycnnjob --name=mycnnjob --namespace=kf-test
INFO  Writing component at '/home/knobby/kubeflow/components/mycnnjob.jsonnet'
 knobby  ~/kubeflow  ks apply cdk -c mycnnjob
ERROR generate objects for namespace : unable to read /home/knobby/kubeflow/environments/cdk/main.jsonnet: RUNTIME ERROR: Missing argument: tp
-------------------------------------------------
	/home/knobby/kubeflow/components/mycnnjob.jsonnet:85:7-51	thunk <job> from <$>

      tfJob.parts.tfJob(name, namespace, replicas) + {

-------------------------------------------------
	/home/knobby/kubeflow/components/mycnnjob.jsonnet:(85:7)-(90:8)	thunk <job> from <$>

      tfJob.parts.tfJob(name, namespace, replicas) + {
        spec+: {
          tfImage: image,
          terminationPolicy: { chief: { replicaName: "WORKER", replicaIndex: 0 } },
        },
      };

-------------------------------------------------
	/home/knobby/kubeflow/components/mycnnjob.jsonnet:92:31-34	thunk from <thunk from <thunk from <$>>>

std.prune(k.core.v1.list.new([job]))

-------------------------------------------------
	<std>:1022:60-61	thunk from <thunk from <function <anonymous>>>

            [ std.prune(x) for x in a if isContent($.prune(x)) ]

-------------------------------------------------
	<std>:1020:28-29	thunk from <thunk <t> from <function <anonymous>>>

        local t = std.type(a);

-------------------------------------------------
	<builtin>	builtin function <type>

-------------------------------------------------
	<std>:1021:12-13	function <anonymous>

        if t== "array" then

-------------------------------------------------
	<std>:969:29-30	thunk from <thunk <ta> from <function <anonymous>>>

        local ta = std.type(a);

-------------------------------------------------
	<builtin>	builtin function <type>

-------------------------------------------------
	<std>:971:33-35	thunk from <function <anonymous>>

        if !std.primitiveEquals(ta, tb) then

-------------------------------------------------
	... (skipped 17 frames)
-------------------------------------------------
	<std>:971:33-35	thunk from <function <anonymous>>

        if !std.primitiveEquals(ta, tb) then

-------------------------------------------------
	<builtin>	builtin function <primitiveEquals>

-------------------------------------------------
	<std>:971:12-40	function <anonymous>

        if !std.primitiveEquals(ta, tb) then

-------------------------------------------------
		

-------------------------------------------------
	<std>:1025:45-71	function <anonymous>

            for x in std.objectFields(a) if isContent(std.prune(a[x]))

-------------------------------------------------
	<builtin>	builtin function <flatMap>

-------------------------------------------------
	<builtin>	builtin function <$objectFlatMerge>

-------------------------------------------------
	/home/knobby/kubeflow/components/mycnnjob.jsonnet:92:1-37	$

std.prune(k.core.v1.list.new([job]))

-------------------------------------------------
	<extvar:__ksonnet/components>:2:13-70	object <anonymous>

  mycnnjob: import "/home/knobby/kubeflow/components/mycnnjob.jsonnet",

-------------------------------------------------
	During manifestation

 knobby  ~/kubeflow  1  ks version
ksonnet version: 0.9.1
jsonnet version: v0.9.5
client-go version: 1.8

[jlewi]

I see the problem; #444 add the tp argument to the tfJob in tfJob.libsonnet and this broke the tf-cnn component.