Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build TFServing images for different TF versions #468

Closed
jlewi opened this issue Mar 20, 2018 · 7 comments
Closed

Build TFServing images for different TF versions #468

jlewi opened this issue Mar 20, 2018 · 7 comments
Assignees

Comments

@jlewi
Copy link
Contributor

jlewi commented Mar 20, 2018

We should probably build different versions of TFServing images corresponding to different TF versions.

@jlewi jlewi changed the title Build TFServing images for different TF images Build TFServing images for different TF versions Mar 26, 2018
@jlewi
Copy link
Contributor Author

jlewi commented Apr 9, 2018

Is the HTTP Proxy TF Version specific?

@lluunn
Copy link
Contributor

lluunn commented Apr 9, 2018

No that should work for all TF versions.

@pdmack
Copy link
Member

pdmack commented Apr 10, 2018

Some strategy discussion in #608

@ankushagarwal
Copy link
Contributor

Should we use the same strategy as jupyter notebook images?

 gcr.io/kf-images/tensorflow-serving-1.4.1-cpu  
 gcr.io/kf-images/tensorflow-serving-1.4.1-gpu  
 gcr.io/kf-images/tensorflow-serving-1.5.1-cpu  
 gcr.io/kf-images/tensorflow-serving-1.5.1-gpu  
 gcr.io/kf-images/tensorflow-serving-1.6.0-cpu  
 gcr.io/kf-images/tensorflow-serving-1.6.0-gpu  
 gcr.io/kf-images/tensorflow-serving-1.7.0-cpu  
 gcr.io/kf-images/tensorflow-serving-1.7.0-gpu

@lluunn lluunn self-assigned this Apr 30, 2018
@lluunn
Copy link
Contributor

lluunn commented May 4, 2018

We should have different tf version, cpu/gpu, and py2/py3 combination for TF serving image as above, e.g. gcr.io/kf-images/tensorflow-serving-1.6.0-py3-cpu

  • jupyter notebook installs py2 and py3 together, but I think we have to separate that in serving case.
  • Jupyter notebook has parameterized Docker image.
  • The logic is embedded in the workflow

I think it's a little hard to read and maintain. And it's hard for users if they want to customize.

How about listing the parameters in a file (yaml or json), and the workflow runs a script to read from the file and build the image?

cc @ankushagarwal

@ankushagarwal
Copy link
Contributor

I think it's a little hard to read and maintain. And it's hard for users if they want to customize.

We should think of a simpler unified approach for building our images - jupyter notebook images, tf-operator images and tf-serving images - #666 would be a good place to track this.

@jlewi
Copy link
Contributor Author

jlewi commented May 14, 2018

@lluunn Is this item done? Can we close this issue?

@lluunn lluunn closed this as completed May 14, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Nov 1, 2019
add gcp basic-auth-ingress application overlay
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Feb 15, 2021
elenzio9 pushed a commit to arrikto/kubeflow that referenced this issue Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants