Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E test for bootstrapper #742

Closed
jlewi opened this issue Apr 30, 2018 · 5 comments
Closed

E2E test for bootstrapper #742

jlewi opened this issue Apr 30, 2018 · 5 comments
Assignees
@kunmingg
Labels
area/testing priority/p1

Comments

@jlewi
Copy link
Contributor

jlewi commented Apr 30, 2018

We should have an E2E test for the bootstrapper.

We could modify/fork our existing E2E test to use the bootstrapper.

/assign @kunmingg
@jlewi
Copy link
Contributor Author

jlewi commented Apr 30, 2018

/assign @kunmingg

@kunmingg
Copy link
Contributor

kunmingg commented May 4, 2018

@jlewi
Added #758 to current sprint.
How about use e2e to cover this case #758 as first step?

@jlewi jlewi mentioned this issue May 11, 2018
Merged
@jlewi
Copy link
Contributor Author

jlewi commented May 14, 2018

@kunmingg What's the current status of this?

@kunmingg
Copy link
Contributor

@jlewi Will create PR today.

@kunmingg kunmingg mentioned this issue May 15, 2018
Merged
@kunmingg
Copy link
Contributor

/close

yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Feb 15, 2021
@gaocegege @k8s-ci-robot
feat: Add suggestion controller (kubeflow#742)
e9cc353 
* feat: Add suggestio controller

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: gofmt

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Fix name

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Add error output

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Fix RBAC

Signed-off-by: Ce Gao <gaoce@caicloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kunmingg kunmingg

Labels
area/testing priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlewi @k8s-ci-robot @kunmingg