Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to run TfCnn example from User Guide: ERROR find objects: parse jsonnet snippet: params.libsonnet:22:5-13 Expected a comma before next field. #863

Closed
dakoner opened this issue May 23, 2018 · 4 comments

Comments

@dakoner
Copy link

dakoner commented May 23, 2018

I am getting an error when I try to run the TfCnn example from the User Guide:
The docs say to run:

CNN_JOB_NAME=mycnnjob
ks generate tf-cnn ${CNN_JOB_NAME} --name=${CNN_JOB_NAME}
ks apply ${KF_ENV} -c ${CNN_JOB_NAME}

I get the error:
ERROR find objects: parse jsonnet snippet: params.libsonnet:22:5-13 Expected a comma before next field.

When I looked at components/params.libsonnet, I see it has added a 'mycynnjob' stanza after the components stanza, but it omits the comma between the two components:

components: {
// Component-level parameters, defined initially from 'ks prototype use ...'
// Each object below should correspond to a component in the components/ directory
....
} /// THERE NEEDS TO BE A TRAILING COMMA HERE
mycnnjob: {
batch_size: 32,
....
}

I'm not sure why this is happening, I guess it is some sort of issue with 'ks generate'?

@ankushagarwal
Copy link
Contributor

  • What version of ksonnet are you using?
  • What version of kubeflow are you using?

ks version 0.10.2 and kubeflow version v0.1.2 seems to work for me

@jlewi
Copy link
Contributor

jlewi commented May 24, 2018

Per @ankushagarwal 's comment components/params.libsonnet is generated by ks not us so its most likely something with ks.

@dakoner
Copy link
Author

dakoner commented May 24, 2018

Yep, I think what's happened is that I downloaded the 'ks' binary from the ksonnet site, and it embeds versions of those files, then blindly updates them without respecting syntax.

@dakoner
Copy link
Author

dakoner commented May 24, 2018

Closing because it's not kubeflow-specific.

@dakoner dakoner closed this as completed May 24, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Feb 15, 2021
* Fix worker error silent

* Use 3rd golang tail to replace linux os command

* Rename sidecar container name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants