Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Katib work with reverse proxy and ambassador #991

Closed
lluunn opened this issue Jun 13, 2018 · 4 comments
Closed

Make Katib work with reverse proxy and ambassador #991

lluunn opened this issue Jun 13, 2018 · 4 comments
Labels
area/0.3.0 priority/p1

Comments

@lluunn
Copy link
Contributor

lluunn commented Jun 13, 2018

  • ModelDB UI is now only accessible by port-forwarding. We should make it work with reverse proxy and ambassador.
  • vizier-core is also used via port-forwarding. It's a gRPC service, so need the ingress that supports gRPC.
@lluunn lluunn mentioned this issue Jun 13, 2018
Closed
@jlewi
Copy link
Contributor

jlewi commented Jun 14, 2018

@lluunn Can we give this issue a more relevant title?

What is the vizier-core service used for? Why does this need to be behind ingress? I expect the only communication from outside the cluster would be to the UI and the CLI. Is the CLI using gRPC?

/cc @YujiOshima

@YujiOshima
Copy link
Contributor

@jlewi Yes, the CLI is using gRPC.
The client communicates vizier-core with gRPC port 6789.

@lluunn lluunn changed the title Katib component improvement Make Katib work with reverse proxy and ambassador Jun 14, 2018
@jlewi
Copy link
Contributor

jlewi commented Jun 15, 2018

@lluunn Should we refile this as an issue in the Katib repo?

@lluunn
Copy link
Contributor Author

lluunn commented Jun 15, 2018

Ah sure

@lluunn lluunn closed this as completed Jun 15, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Feb 15, 2021
@gaocegege @k8s-ci-robot
feat: Support resource in sidecar (kubeflow#991)
c8cb2cb 
* feat: Support resource in sidecar

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* feat: Support webhook service name

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* feat: Fix

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Have a large mem

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Fix import

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Add comma

Signed-off-by: Ce Gao <gaoce@caicloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/0.3.0 priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlewi @YujiOshima @lluunn