Add test for tf-job-simple prototype #1010
Conversation
ankushagarwal
changed the title
ankushagarwal
changed the title
| @retry(wait_fixed=5000, stop_max_attempt_number=20) | ||
| def wait_for_tf_job(): | ||
| out = util.run(["kubectl", "get", "pods", "-l", | ||
| "tf_job_name=mycnnjob", "-ndefault"]) |
There was a problem hiding this comment.
If namespace is default, do we need to delete them? I guess jobs will gone after finish, how about the service?
There was a problem hiding this comment.
We will be deleting the cluster at the end so I did not bother deleting this.
There was a problem hiding this comment.
Are we using kubeflow-testing cluster in kubeflow-ci?
There was a problem hiding this comment.
No, we'll be creating a new cluster for every test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lluunn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add test for tf-job-simple prototype Fixes kubeflow#462 * Update * Update * Update
* feat: Do not inject sh -c when it exists Signed-off-by: Ce Gao <gaoce@caicloud.io> * fix: Add test cases Signed-off-by: Ce Gao <gaoce@caicloud.io> * fix: Add test cases Signed-off-by: Ce Gao <gaoce@caicloud.io>
* Use a configmap generator for the spawner_ui_config.yaml
* Using a configmap generator is a bit cleaner because we can store
the configuration file in a external file rather than inlining it in
the config map.
* Using a configmap generator also has the advantage that kustomize will
generate a unique name based on a hash of the content.
* This has the advantage that if a user updates the config, the hash
would change so deployments would automatically be redeployed in order
to pick up the config changes.
* Also update the default image used in the configmap to fix kubeflow#1010
* Rebase and regenerate the tests.
* * The deployment for the UI needs to use the original name of
the jupyter web app config map without the prefix/suffix.
* Update expected tests.
tf_job_simple_test.py tests the tf-job-simple prototype by creating a tfjob from that prototype and checking that the appropriate pods and service accounts get created
Fixes #462
This change is