Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tf_operator image to point to tag v0.2.0 #1062

Merged
merged 1 commit into from Jun 22, 2018

Conversation

kunmingg
Copy link
Contributor

@kunmingg kunmingg commented Jun 21, 2018

Want to cherry-pick to new rc.

Now tf_operator:v0.2.0 contains fixes in: #1024 (comment)


This change is Reviewable

@kunmingg kunmingg requested review from ankushagarwal and removed request for jimexist and willingc June 21, 2018 23:13
@kunmingg
Copy link
Contributor Author

/assign @lluunn

@lluunn
Copy link
Contributor

lluunn commented Jun 21, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kunmingg
Copy link
Contributor Author

/retest

1 similar comment
@kunmingg
Copy link
Contributor Author

/retest

@kunmingg
Copy link
Contributor Author

/test all

@pdmack
Copy link
Member

pdmack commented Jun 22, 2018

#980 ?

@pdmack
Copy link
Member

pdmack commented Jun 22, 2018

"Insufficient regional quota\                                                   
\ to satisfy request for resource: \\\"INSTANCE_GROUPS\\\". The request requires\                                                    
\ '1.0' and is short '1.0'. The regional quota is '100.0' with '0.0' available.\"\                                                   
,\"status\":\"PERMISSION_DENIED\",\"statusMessage\":\"Forbidden\",\"requestPath\"\                                                   
:\"https://container.googleapis.com/v1/projects/kubeflow-ci/zones/us-east1-d/clusters\"\                                             
,\"httpMethod\":\"POST\"}}"

@kunmingg
Copy link
Contributor Author

/retest

@kunmingg
Copy link
Contributor Author

/test all

@k8s-ci-robot k8s-ci-robot merged commit 3831309 into kubeflow:master Jun 22, 2018
kunmingg added a commit to kunmingg/kubeflow that referenced this pull request Jun 22, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
…ow#1094)

* Add default-install

* Convert default-install to v3.

* For default-install we need to change the name of the configmap to match
  the configmap that will be generated by kfctl.

Related to kubeflow#1062

* * Modify spartakus to work with v3 and stacks; we need to change the
  config map name to match the config map generated by kfctl with
  application parameters.

* Include kubeflow-roles.

* Fix and regenerate the tests.

* To fix the tests we need to change the name of the config maps.
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
…ubeflow#1144)

* Create an updated style/best practices guide for kustomize packages.

* See http://bit.ly/kf_kustomize_v3

* Its been over a year since we started migrating to kustomize. In that time
kustomize has evolved and we have learned a lot about how to use
kustomize effectively.

* Some of the initial usage patterns have turned out to be problematic (e.g. vars) and there are now better options.

* Update the style guide to better document best practices.

Related to kubeflow#1062

* Fix.

* Address comments.
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
* For GCP will not be using KFDef with 1.1; instead we will be using
  blueprints (see kubeflow#1063)

* Therefore I updated the existing example of deploying using stacks
  to make it non GCP specific so that it could be used as an example
  for platforms that still want to use KFDef.

  * kubeflow#1062 is tracking migrating all KFDefs to the new versions
    of our kustomize packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants