New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tf_operator image to point to tag v0.2.0 #1062
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunmingg
requested review from
ankushagarwal
and removed request for
jimexist and
willingc
June 21, 2018 23:13
/assign @lluunn |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lluunn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/test all |
#980 ? |
|
/retest |
/test all |
kunmingg
added a commit
to kunmingg/kubeflow
that referenced
this pull request
Jun 22, 2018
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jun 22, 2018
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
surajkota
pushed a commit
to surajkota/kubeflow
that referenced
this pull request
Jun 13, 2022
…ow#1094) * Add default-install * Convert default-install to v3. * For default-install we need to change the name of the configmap to match the configmap that will be generated by kfctl. Related to kubeflow#1062 * * Modify spartakus to work with v3 and stacks; we need to change the config map name to match the config map generated by kfctl with application parameters. * Include kubeflow-roles. * Fix and regenerate the tests. * To fix the tests we need to change the name of the config maps.
surajkota
pushed a commit
to surajkota/kubeflow
that referenced
this pull request
Jun 13, 2022
…ubeflow#1144) * Create an updated style/best practices guide for kustomize packages. * See http://bit.ly/kf_kustomize_v3 * Its been over a year since we started migrating to kustomize. In that time kustomize has evolved and we have learned a lot about how to use kustomize effectively. * Some of the initial usage patterns have turned out to be problematic (e.g. vars) and there are now better options. * Update the style guide to better document best practices. Related to kubeflow#1062 * Fix. * Address comments.
surajkota
pushed a commit
to surajkota/kubeflow
that referenced
this pull request
Jun 13, 2022
* For GCP will not be using KFDef with 1.1; instead we will be using blueprints (see kubeflow#1063) * Therefore I updated the existing example of deploying using stacks to make it non GCP specific so that it could be used as an example for platforms that still want to use KFDef. * kubeflow#1062 is tracking migrating all KFDefs to the new versions of our kustomize packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to cherry-pick to new rc.
Now tf_operator:v0.2.0 contains fixes in: #1024 (comment)
This change is