Delete the tf-job package. #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The tf-job package only contains an outdated prototype for TFJobs. This is currently broken because the version was changed to v1alpha2 but the spec wasn't actually updated. * Per discussions elsewhere we are moving towards structuring templates for TFJobs as prototypes in the examples package. We want the full spec to be in the prototype so that when a component is generated from the prototype users can easily modify it to do advanced customizations. Fix kubeflow#1049
|
/assign @kunmingg |
|
Can you clarify ? What is the recommended way to create a tf job now ? I
think, we still need a easy way that can be used to create a basic job.
If we are going ahead with deleting TFjob, we have to update readme and
user guide.
…On Thu, Jun 28, 2018, 3:25 PM k8s-ci-robot ***@***.***> wrote:
@jlewi <https://github.com/jlewi>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
kubeflow-presubmit e268b87
<e268b87>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/kubeflow_kubeflow/1091/kubeflow-presubmit/2299/> /test
kubeflow-presubmit
Full PR test history
<https://k8s-gubernator.appspot.com/pr/kubeflow_kubeflow/1091>. Your PR
dashboard <https://k8s-gubernator.appspot.com/pr/jlewi>. Please help us
cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubeflow/kubeflow/issues?q=is:issue+is:open> when you
hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1091 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACEj_3-c_AQVfVQAsFo76BfEdyghDhN4ks5uBKgHgaJpZM4U7DUQ>
.
|
|
The preferred way to create a TFJob v1alpha2 is |
|
Sent kubeflow/website#71 to update the website. |
|
/test all Looks like there was a timeout waiting for workflows but the workflows actually ran too completion. |
|
@kunmingg ping |
kunmingg
reviewed
Jun 29, 2018
There was a problem hiding this comment.
@jlewi Can you remove tf-job from kubeflow registry as well? https://github.com/kubeflow/kubeflow/blob/master/kubeflow/registry.yaml
|
And the 2 config file here |
|
Will cherry-pick to release branch once merged. Thanks! |
Merged
* The tf-job-simple prototype should not have field tfImage.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kunmingg
pushed a commit
to kunmingg/kubeflow
that referenced
this pull request
Jun 29, 2018
* Delete the tf-job package. * The tf-job package only contains an outdated prototype for TFJobs. This is currently broken because the version was changed to v1alpha2 but the spec wasn't actually updated. * Per discussions elsewhere we are moving towards structuring templates for TFJobs as prototypes in the examples package. We want the full spec to be in the prototype so that when a component is generated from the prototype users can easily modify it to do advanced customizations. Fix kubeflow#1049 * Remove tf-job package from the bootstrapper. * * Remove some references to TfJob package. * The tf-job-simple prototype should not have field tfImage. * * Remove terminationPolicy its not part of the v1alpha2 spec.
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
* Delete the tf-job package. * The tf-job package only contains an outdated prototype for TFJobs. This is currently broken because the version was changed to v1alpha2 but the spec wasn't actually updated. * Per discussions elsewhere we are moving towards structuring templates for TFJobs as prototypes in the examples package. We want the full spec to be in the prototype so that when a component is generated from the prototype users can easily modify it to do advanced customizations. Fix kubeflow#1049 * Remove tf-job package from the bootstrapper. * * Remove some references to TfJob package. * The tf-job-simple prototype should not have field tfImage. * * Remove terminationPolicy its not part of the v1alpha2 spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tf-job package only contains an outdated prototype for TFJobs. This is
currently broken because the version was changed to v1alpha2 but the spec
wasn't actually updated.
Per discussions elsewhere we are moving towards structuring templates for
TFJobs as prototypes in the examples package. We want the full spec
to be in the prototype so that when a component is generated from the
prototype users can easily modify it to do advanced customizations.
Fix #1049
This change is