Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tfjob create fails in tfjob UI #1099

Merged
merged 3 commits into from Jun 29, 2018
Merged

Conversation

kkasravi
Copy link
Contributor

@kkasravi kkasravi commented Jun 28, 2018

See kubeflow/training-operator#701


This change is Reviewable

@kkasravi
Copy link
Contributor Author

/assign @swiftdiaries

@kkasravi
Copy link
Contributor Author

/cc @jlewi

@k8s-ci-robot k8s-ci-robot requested a review from jlewi June 29, 2018 13:08
@@ -4,6 +4,6 @@
registries:
- name: kubeflow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you upgrading this file? Can you revert it back to the original value and not use kkassarvi?

Here's the process I follow to do debugging

  1. Follow kubeflow.org to deploy on GCP
  2. Run this command to copy your ksonnet app to your local machine
    https://www.kubeflow.org/docs/started/getting-started-gke/
  3. Replace vendor/kubeflow with a symbolic link to your code; this way you will pick up changes to your ksonnet component
  4. Recreate the K8s resources to pick up your changes.

@kkasravi
Copy link
Contributor Author

/retest

@jlewi
Copy link
Contributor

jlewi commented Jun 29, 2018

Thanks.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6c2c69b into kubeflow:master Jun 29, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* fixes unable to create a tfjob in the UI

* fix for unable to create a tfjob in the UI

* revert image_registries.yaml back to master version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants