Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add katib releaser #1102

Merged
merged 1 commit into from Jul 9, 2018
Merged

Conversation

YujiOshima
Copy link
Contributor

@YujiOshima YujiOshima commented Jun 29, 2018

I want to release 7 images for Katib.

  • vizier-core
  • suggestion-random
  • suggestion-grid
  • suggestion-hyperband
  • suggestion-bayesianoptimization
  • earlystopping-medianstopping
  • katib-frontend

@kunmingg Please take a look.


This change is Reviewable

@kunmingg
Copy link
Contributor

@YujiOshima
Did you forget to include the actual release ks app? (should be at kubeflow/kubeflow/releasing/katib, like pytorch)

@YujiOshima
Copy link
Contributor Author

@kunmingg Do you mean pytorch-operator.jsonnet ?
I added katib.jsonnet.

dockerfile: "Dockerfile",
dockerfileDir: "kubeflow/pytorch-operator",
extra_args: "/mnt",
extra_repos: "kubeflow/testing@HEAD;kubeflow/pytorch-operator@HEAD",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be katib repo

@kunmingg
Copy link
Contributor

kunmingg commented Jul 2, 2018

Presubmit failed on format check, can use jsonnet fmt following docs
Otherwise lgtm.

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
@YujiOshima
Copy link
Contributor Author

@kunmingg Thank you for your advice!
I updated. PTAL

@kunmingg
Copy link
Contributor

kunmingg commented Jul 6, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kunmingg
Copy link
Contributor

kunmingg commented Jul 6, 2018

/retest

2 similar comments
@YujiOshima
Copy link
Contributor Author

/retest

@kunmingg
Copy link
Contributor

kunmingg commented Jul 9, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit cce6091 into kubeflow:master Jul 9, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
* Fix custom Katib DB Manager info

* Change names for Katib db manager env
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants