-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kaggle notebook Dockerfile #1109
Conversation
/retest |
This is great. Do you have a prebuilt image that I can push to our public registry? You should be able to push to gcr.io/kubeflow-dev /lgtm |
@jlewi I'll try to push something later today. |
It's up there at kubeflow-dev but getting a SIGABRT running MNIST hello world in d.k.o. Stay tuned. |
Heh, guess the only place I can test this is on my i7-4870HQ:
|
/retest @jlewi, MNIST hello world works on my 2015 MBP (AVX2). Weighs in at a svelte 27 Gb!
|
/test all |
GPU test failures look unrelated. |
/test all |
1 similar comment
/test all |
#1128 for the latest test flake. /test all |
Latest failure looks like a timeout waiting for the minikube workflow; but that ultimately ran successfully. /test all |
This is fun |
Another timeout but looks like workflows succeeded. Let me bump the timeout. |
* In kubeflow/kubeflow#1109 We are seeing lots of timeouts waiting for the test workflows too complete. * Bump the timeout to 1 hour.
minikube is the bane of our e2e existence |
* In kubeflow/kubeflow#1109 We are seeing lots of timeouts waiting for the test workflows too complete. * Bump the timeout to 1 hour.
@jlewi I think we now have an MVP at gcr.io/kubeflow-dev/kubeflow-kaggle-notebook:latest PTAL and cancel hold if you feel it's ready
Built for AVX2 |
/retest |
9e9e4af
to
75bba1c
Compare
Retagged it gcr.io/kubeflow-images-public/kaggle-notebook:v20180711 |
Be gentle |
When I tried gcr.io/kubeflow-images-public/kaggle-notebook:v20180711 I got the error
|
I took out too much in that last cut. Stay tuned. |
Update: Just trying to wrangle the addition of the jupyterhub package. It is surprisingly more disruptive than expected. |
@jlewi please retry
Actually I'm assuming that, but maybe this happens in the original also. |
Thanks I'm on the road today so might not get to it until this weekend
…On Fri, Jul 13, 2018, 9:51 AM Pete MacKinnon ***@***.***> wrote:
@jlewi <https://github.com/jlewi> please retry
gcr.io/kubeflow-dev/kubeflow-kaggle-notebook:latest
feel a little more confident in this one
but adding jupyterhub 0.8.1 triggers some incompats
tensorflow 1.9.0rc0 has requirement setuptools<=39.1.0, but you'll have setuptools 40.0.0 which is incompatible.
kmodes 0.9 has requirement scikit-learn<0.20.0,>=0.19.0, but you'll have scikit-learn 0.20.dev0 which is incompatible.
kmeans-smote 0.1.0 has requirement imbalanced-learn<0.4,>=0.3.1, but you'll have imbalanced-learn 0.4.0.dev0 which is incompatible.
kmeans-smote 0.1.0 has requirement scikit-learn<0.20,>=0.19.0, but you'll have scikit-learn 0.20.dev0 which is incompatible.
hep-ml 0.5.0 has requirement theano==0.8.2, but you'll have theano 1.0.2 which is incompatible.
fastai 0.7.0 has requirement torch<0.4, but you'll have torch 0.4.0 which is incompatible.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1109 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAvcAwah8dUtMOohXkp7DVoldPVjh2EBks5uGNAvgaJpZM4U9zoq>
.
|
Pushed to: Trying it now. |
Was able to successfully launch a notebook after changing the home directory
I loaded up this notebook. The imports worked. I was missing the data for the notebook so it didn't work. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you so much @pdmack for al the hard working making this work. |
PTL |
/hold cancel |
This enables use cases such as this one: kubeflow/website#180
* Modify prow config * Add examples to prow
Related to #1057 - pytorch notebook image
Related to #258 - Kaggle image
PTAL
/cc @jlewi
/cc @ankushagarwal
/cc @johnugeorge
Launched for me but obviously not exhaustively tested. Created a contrib dir to give it that YMMV vibe.
Notes (IMHO):
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)