Pin and fix katib images. (#1113) #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The latest images are too old; we should be using the images with tag "master"
* For the 0.2 release we want to pin the images to specific images which
we tag 0.2.0
* Delete the protoype parameter katibImagTag; image parameters should provide
the full image reference including the tag. This makes it much easier
to override certain images and is consistent with other components.
* Create a simple, oneoff script to retag the existing Katib images into
the Kubeflow image repository
* We most likely won't ever use this again but its good to leave a paper
trail.
Related to:
kubeflow/katib#133 Katib images in 0.2.0-rc.1 are too old
* Will need to cherry pick this.
Fix kubeflow/katib#132 Get rid of katibImageTag
Fix kubeflow/katib#131 Katib prototype needs to pin docker images
|
/assign @kunmingg Cherry pick a fix for 0.2.1 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunmingg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest |
surajkota
pushed a commit
to surajkota/kubeflow
that referenced
this pull request
Jun 13, 2022
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest images are too old; we should be using the images with tag "master"
For the 0.2 release we want to pin the images to specific images which
we tag 0.2.0
Delete the protoype parameter katibImagTag; image parameters should provide
the full image reference including the tag. This makes it much easier
to override certain images and is consistent with other components.
Create a simple, oneoff script to retag the existing Katib images into
the Kubeflow image repository
trail.
Related to:
kubeflow/katib#133 Katib images in 0.2.0-rc.1 are too old
* Will need to cherry pick this.
Fix kubeflow/katib#132 Get rid of katibImageTag
Fix kubeflow/katib#131 Katib prototype needs to pin docker images
This change is