Make the test robust to test flakes due to problems initializing the ksonnet app #1133
Conversation
|
/assign @ankushagarwal |
|
/approve Let's see if this pays dividends. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pdmack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
|
/lgtm |
|
/test all |
* Make the tf_job_simple test robust to test flakes due to problems initializing the ksonnet app. * Skip install the default registries because we don't need them and talking to Git just creates a source of flakiness. * Add retries to setting up the ksonnet app. Fix kubeflow#1128 * Fix flake in minikube test wait_for_operation should just rety on socket errors. Fix kubeflow#1137
|
/retest |
|
socks? |
|
Latest flake looks like timeout getting status which is I've already pushed a new test worker image. So hopefully its fixed. /test all |
|
Retry window has been increased lets try again. |
|
@pdmack Tests seem to be passing now that we increased the timeouts. |
|
/lgtm |
…ksonnet app (kubeflow#1133) * Fix issues causing test flakes. * Make the tf_job_simple test robust to test flakes due to problems initializing the ksonnet app. * Skip install the default registries because we don't need them and talking to Git just creates a source of flakiness. * Add retries to setting up the ksonnet app. Fix kubeflow#1128 * Fix flake in minikube test wait_for_operation should just rety on socket errors. Fix kubeflow#1137 * Fix incorrect import; sock -> socket.
* Avoid star-imports * Add constants
Skip install the default registries because we don't need them and talking
to Git just creates a source of flakiness.
Add retries to setting up the ksonnet app.
Fix #1128
This change is