Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing errors and missing variables in user guide. #114

Merged
merged 3 commits into from Jan 12, 2018

Conversation

elsonrodriguez
Copy link
Contributor

@elsonrodriguez elsonrodriguez commented Jan 11, 2018

There were a few missing things that prevented the guide from being completed successfully.

Haven't tested the Advanced section.

There were a few missing things that prevented the guide from being completed successfully.
@k8s-ci-robot
Copy link
Contributor

Hi @elsonrodriguez. Thanks for your PR.

I'm waiting for a kubernetes or google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@jlewi jlewi merged commit f07c87d into kubeflow:master Jan 12, 2018
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Nov 1, 2019
* Add kubebench-operator-v1alpha2

* Added ocnfigmap

* tests fixed

* kubebench-job deleted

* update images

* dashboard deleted

* added config-map mount

* fix

* final fix

* new line added
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
* add e2e test

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* fix

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* fix

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* split cli from manager build

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* fix

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* fix

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* print pod status

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* print deploy svc

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* fix

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* use pod for port-forward

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* fix

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* fix

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* wait vixier-core

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>

* fix

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants