Make Katib work with Ambassador. (#1103) #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Katib uses "/katib" as the route path; so we change the Ambassador mapping to use /katib and not /modeldb as the prefix. * I was able to load /katib/projects successfully behind IAP with this change I didn't actually try to use it though. Fix: kubeflow/katib#118
|
/assign @kunmingg |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunmingg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
surajkota
pushed a commit
to surajkota/kubeflow
that referenced
this pull request
Jun 13, 2022
Update Katib Application owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry pick of #1103 into the 0.2 branch
Katib uses "/katib" as the route path; so we change the Ambassador mapping
to use /katib and not /modeldb as the prefix.
I was able to load /katib/projects successfully behind IAP with this change
I didn't actually try to use it though.
Fix: kubeflow/katib#118
This change is