Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give KF_USER_NAME service account roles/cloudbuild.builds.editor role #1163

Merged
merged 1 commit into from Jul 11, 2018
Merged

Give KF_USER_NAME service account roles/cloudbuild.builds.editor role #1163

merged 1 commit into from Jul 11, 2018

Conversation

ankushagarwal
Copy link
Contributor

@ankushagarwal ankushagarwal commented Jul 10, 2018

This allows us to submit docker builds to google cloud container builder

/cc @jlewi


This change is Reviewable

This allows us to submit docker builds to google cloud container builder

/cc @jlewi
@jlewi
Copy link
Contributor

jlewi commented Jul 11, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e7e16c4 into kubeflow:master Jul 11, 2018
@ankushagarwal ankushagarwal deleted the permissions-build-editor branch July 11, 2018 15:37
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
…kubeflow#1163)

This allows us to submit docker builds to google cloud container builder

/cc @jlewi
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
This was reverted in a03973b due to
test failures. This re-introduces the packages with the issues fixed.

See kubeflow#1141 for more context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants