Cherry Pick: Don't check in bootstrap/vendor. (#1152) #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This bloats the repository size by 150M +. * Since we want to be able to quickly clone the repo using to facilitate getting our ksonnet registry; we want to avoid bloating the repository. * We create a builder image which is Go + glide since we don't introduce flakiness trying to fetch glide. Fix: 1051
|
/assign @ankushagarwal |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Feb 15, 2021
* Support strings metric values * Fix tests
surajkota
pushed a commit
to surajkota/kubeflow
that referenced
this pull request
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bloats the repository size by 150M +.
Since we want to be able to quickly clone the repo using to facilitate
getting our ksonnet registry; we want to avoid bloating the repository.
We create a builder image which is Go + glide since we don't introduce
flakiness trying to fetch glide.
Fix: 1051
This change is