New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherrypick #1194 to master - Fix deploy.sh moving the unpacked repo #1196
Conversation
* Fix deploy.sh moving the unpacked repo. * It looks like GitHub is stripping out the v in the name of the top level directory. Make the scripts less brittle by not assuming the top level directory will be named a certain way. Related to 1193. * Fix indent. * * Add simple test scripts to verify that the configs are created * Add an option to gke/deploy.sh to skip deployment to facilitate testing * Add an option to gke/deploy.sh to not recreate the DM configs if they already exist; the sed commands assume we are starting from scratch.
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
/assign @jlewi |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ankushagarwal: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* Fix deploy.sh moving the unpacked repo. * It looks like GitHub is stripping out the v in the name of the top level directory. Make the scripts less brittle by not assuming the top level directory will be named a certain way. Related to 1193. * Fix indent. * * Add simple test scripts to verify that the configs are created * Add an option to gke/deploy.sh to skip deployment to facilitate testing * Add an option to gke/deploy.sh to not recreate the DM configs if they already exist; the sed commands assume we are starting from scratch.
* Add GCS scope to the VM service account otherwise we won't be able to pull private images. * Create an OWNERs file inside the GCP directory.
Fix deploy.sh moving the unpacked repo.
It looks like GitHub is stripping out the v in the name of the top level
directory.
Make the scripts less brittle by not assuming the top level directory
will be named a certain way.
Related to #1193.
Fix indent.
Add an option to gke/deploy.sh to skip deployment to facilitate testing
Add an option to gke/deploy.sh to not recreate the DM configs if they
already exist; the sed commands assume we are starting from scratch.
This change is