Fix tfjob test; the simple tfjob test prototype was renamed. #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @ankushagarwal |
|
/lgtm |
|
it's still failing with job not found |
|
ref #1266 |
lluunn
reviewed
Jul 25, 2018
| @@ -418,7 +418,7 @@ | |||
| "--project=" + project, | |||
| "--app_dir=" + tfOperatorRoot + "/test/workflows", | |||
| "--tfjob_version=v1alpha1", | |||
| "--component=simple_tfjob", | |||
| "--component=simple_tfjob_v1alpha2", | |||
* kubeflow/training-operator#749 renamed the prototype * ksonnet just fails silently if the component doesn't exist so the test just ends up failing with 404 trying to wait for the job. * Fix 1266 * Update the test to use v1alpha2 for tf_job_version. * Remove code to run v1alpha1 and v1alpha2; we can only run one version because only 1 CRD version can be installed in the cluster. * The default should be v1alpha2 so lets just test that. * Don't use the mnist image with v1alpha2; use tf_smoke and use the image set in the job prototype.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal, lluunn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
richardsliu
pushed a commit
to richardsliu/kubeflow
that referenced
this pull request
Aug 21, 2018
…w#1267) * Fix tfjob test; the simple tfjob test prototype was renamed. * kubeflow/training-operator#749 renamed the prototype * ksonnet just fails silently if the component doesn't exist so the test just ends up failing with 404 trying to wait for the job. * Fix 1266 * Update the test to use v1alpha2 for tf_job_version. * Remove code to run v1alpha1 and v1alpha2; we can only run one version because only 1 CRD version can be installed in the cluster. * The default should be v1alpha2 so lets just test that. * Don't use the mnist image with v1alpha2; use tf_smoke and use the image set in the job prototype. * Fix ksonnet error.
richardsliu
added a commit
to richardsliu/kubeflow
that referenced
this pull request
Aug 21, 2018
…ubeflow#1267)" This reverts commit b9f07e1.
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
…w#1267) * Fix tfjob test; the simple tfjob test prototype was renamed. * kubeflow/training-operator#749 renamed the prototype * ksonnet just fails silently if the component doesn't exist so the test just ends up failing with 404 trying to wait for the job. * Fix 1266 * Update the test to use v1alpha2 for tf_job_version. * Remove code to run v1alpha1 and v1alpha2; we can only run one version because only 1 CRD version can be installed in the cluster. * The default should be v1alpha2 so lets just test that. * Don't use the mnist image with v1alpha2; use tf_smoke and use the image set in the job prototype. * Fix ksonnet error.
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Feb 15, 2021
* Change doc for v1beta1 * Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is