New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add components dir to tf serving test #1269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @ankushagarwal |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
* add components dir to tf serving test * fix
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Feb 15, 2021
* Add instructions for FPGA accelerated Experiments * XGBoost FPGA accelerated example * Ommit unnecessary quotes * Add the new example in the list of training container images * Ommit explicit declaration of the metrics collector Co-authored-by: Vaggelis Gkiastas <vaggelisgkia@hotmail.com>
surajkota
pushed a commit
to surajkota/kubeflow
that referenced
this pull request
Jun 13, 2022
* The GCP stack doesn't build (GoogleCloudPlatform/kubeflow-distribution#55). The problem is pipeline GCP manifest is referring to a configmap that doesn't exist * This is a temporary hack to make the manifests build; I just commented out the missing file. * @Bobgy will hopefully add an appropriate long term fix. * The GCP stack was reintroduced in kubeflow#1286. The unittests should have caught this but they didn't because make generate is swallowing errors if there is a problem generating the tests kubeflow#1269 Update the alice example to use the GCP config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @richardsliu
This change is