Enable GKE node-pool autoscaling options #1273
Conversation
|
/assign @ankushagarwal |
|
/retest |
1 similar comment
|
/retest |
scripts/gke/deploy.sh
Outdated
| @@ -38,6 +38,13 @@ check_install uuidgen | |||
|
|
|||
| PRIVATE_CLUSTER=${PRIVATE_CLUSTER:-false} | |||
|
|
|||
| # GKE autoscale parameters | |||
| ENABLE_AUTOSCALE=${ENABLE_AUTOSCALE:-false} | |||
There was a problem hiding this comment.
I don't want to expose options in multiple places. The single source of truth should be the K8s deployment configs.
If people want to change the options they should modify those YAMl files. They can run deploy.sh once and not setup the cluster (by setting setup) false to create the configs and then run it again to actually deploy it.
scripts/gke/deploy.sh
Outdated
|
|
||
| # Update the cluster if autoscaling is desired. | ||
| if ${ENABLE_AUTOSCALE}; then | ||
| gcloud container clusters update ${DEPLOYMENT_NAME} --enable-autoscaling --min-nodes ${DEFAULT_MIN_NODES} --max-nodes ${DEFAULT_MAX_NODES} --zone ${ZONE} --node-pool default-pool |
There was a problem hiding this comment.
We want all configuration to be declarative. Can we add this to the CPU & GPU node pools respectively
https://github.com/kubeflow/kubeflow/blob/master/scripts/gke/deployment_manager_configs/cluster.jinja#L116
|
Done. |
jlewi
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@richardsliu I think you want to rebase off the latest master to fix the tests. |
|
/retest |
1 similar comment
|
/retest |
Move autoscale configurations to jinja and yaml files
|
/retest |
|
/lgtm |
|
@richardsliu: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
fixes #1033 |
Move autoscale configurations to jinja and yaml files
* Add proposal for custom CRD in Trial Template * Fix * Modify doctoc * Doc fixes * Rename header * Fixes * Change doc * Remove comma * Fix Implementation
…ubeflow#1273) * image gcr.io/kubeflow-images-public/pytorch-operator:vmaster-gd596e904 * Image built from kubeflow/kubeflow@d596e904
This change is