Add TFJob test to the Kfctl test; refactor workflows to start to use #1333
Conversation
This PR adds the TFJob simple to that workflow. To support that we start refactoring workflows.libsonnet to make it easy to define an Argo Dag that can be nested in other workflows so we can reuse subgraphs across tests. Related to kubeflow#1325 Reusability of subgraphs in our tests.
jlewi
changed the title
|
/assign @lluunn |
|
Do you want to add testing/ to prowconfig https://github.com/kubeflow/kubeflow/blob/master/prow_config.yaml#L21 Also, I think the variable names in kfTests is confusing. |
|
The test is already being triggered by prow |
|
I take that back looks like its not actually getting triggered. |
|
I think its not being triggered because we aren't including the directory in the prow_config will update. |
* autformat_jsonnet should execute jsonnet format from the root of the git repo since its using paths relative to the root.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi, lluunn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
tide shows not mergeable, not sure why. |
|
Looks like |
…ubeflow#1333) * Start adding component tests to the new kfctl workflow. This PR adds the TFJob simple to that workflow. To support that we start refactoring workflows.libsonnet to make it easy to define an Argo Dag that can be nested in other workflows so we can reuse subgraphs across tests. Related to kubeflow#1325 Reusability of subgraphs in our tests. * * Give the variables better names and add comments. * autformat_jsonnet should execute jsonnet format from the root of the git repo since its using paths relative to the root. * Bump the master version because 1.9.7-gke.3 is no longer supported for the master.
* Init commit * Modify Insert function Add retry on empty observation * Fix mutate volume test * Fix validate experiment test * Fix invalid experiment * Don't get deployed job status when trial is completed * Not send Trial with unavailable metrics to Suggestion * Refactor requeue If objective metric value is not reported metrics collector reports unavailable value to the DB Controller reconciles Trial until DB is empty * Add condition before change trial status * Remove prints * Fix tfevent parser
Start adding component tests to the new kfctl workflow.
This PR adds the TFJob simple to that workflow.
To support that we start refactoring workflows.libsonnet to make it easy to define an Argo Dag that can be nested in other workflows so we can reuse subgraphs across tests.
Related to Reusability and composability of steps in our E2E tests #1325 Reusability of subgraphs in our tests.
This change is