New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds argo to ambassador and Central UI #1376
Conversation
/hold cancel |
/retest |
/test all |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@swiftdiaries, needs rebase. |
/test all |
|
Thanks @pdmack |
/lgtm |
* add argo-ui to ambassador * adds nits, smaller image for centralui * fix argo.libsonnet
* Related to: GoogleCloudPlatform/kubeflow-distribution#74 Fix common labels for knative and kfserving. * There were typos and they were including labels that by convention we currently don't want in common labels.
Addresses: #1310.
Adds small nits and addresses suggestions from: #1242.
This change is