Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the install_minikube.sh script for non-Ubuntu OSes #1384

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Aug 18, 2018

Fixes #1383


This change is Reviewable

@jlewi
Copy link
Contributor

jlewi commented Aug 20, 2018

/ok-to-test

@jlewi
Copy link
Contributor

jlewi commented Aug 20, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 20, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7c5f05b into kubeflow:master Aug 20, 2018
@Ark-kun Ark-kun deleted the patch-1 branch November 8, 2018 22:09
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants