New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix annotations in ambassador and centraldashboard #1399
Fix annotations in ambassador and centraldashboard #1399
Conversation
/assign @jlewi |
nit: Can you add comments in both .libsonnet files explaining why we do this and the fact that we can remove it once we are willing to depend on ksonnet 0.12 |
Done. |
/lgtm |
/retest |
/lgttm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Opened #1407 about the argo deploy test failures |
/test all |
* Fix kubeflow#1306 * Format jsonnet * Comments
Fix #1306
This change is