Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kfctl.sh gcpInitProject is always skipped #1425

Merged
merged 1 commit into from Sep 11, 2018

Conversation

sambaiz
Copy link
Member

@sambaiz sambaiz commented Aug 25, 2018

  • Fix if statements

This change is Reviewable

@sambaiz
Copy link
Member Author

sambaiz commented Aug 25, 2018

/assign @kunmingg

@kunmingg
Copy link
Contributor

/lgtm
/approve

@kunmingg
Copy link
Contributor

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pdmack
Copy link
Member

pdmack commented Sep 10, 2018

/retest

@pdmack
Copy link
Member

pdmack commented Sep 10, 2018

Not sure about those test failures but could you rebase your changes?

@sambaiz
Copy link
Member Author

sambaiz commented Sep 11, 2018

/retest

2 similar comments
@kunmingg
Copy link
Contributor

/retest

@abhi-g
Copy link
Member

abhi-g commented Sep 11, 2018

/retest

@abhi-g
Copy link
Member

abhi-g commented Sep 11, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 2a330ad into kubeflow:master Sep 11, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants