Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes add ability to only generate parts of a component in the jsonnet file #1487

Merged
merged 7 commits into from Sep 8, 2018

Conversation

kkasravi
Copy link
Contributor

@kkasravi kkasravi commented Sep 5, 2018

fixes #1486


This change is Reviewable

@kkasravi
Copy link
Contributor Author

kkasravi commented Sep 5, 2018

/assign @jlewi

@kkasravi
Copy link
Contributor Author

kkasravi commented Sep 5, 2018

/assign @ankushagarwal

@kkasravi
Copy link
Contributor Author

kkasravi commented Sep 7, 2018

/retest

1 similar comment
@kkasravi
Copy link
Contributor Author

kkasravi commented Sep 7, 2018

/retest

@pdmack
Copy link
Member

pdmack commented Sep 8, 2018

need to rebase for #1494

@pdmack
Copy link
Member

pdmack commented Sep 8, 2018

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pdmack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kkasravi
Copy link
Contributor Author

kkasravi commented Sep 8, 2018

thanks @pdmack !
This makes some minor improvements on a prior PR merged 3 days ago #1437

@k8s-ci-robot k8s-ci-robot merged commit ea09d94 into kubeflow:master Sep 8, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
…t file (kubeflow#1487)

* fixes add ability to only generate parts of a component in the jsonnet file

* fix for Computed imports are not allowed

* /retest

* /retest

* due to error: find objects: RUNTIME ERROR: couldn't manifest function in JSON output - make generation of list explicit by using all
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
…nd previous (kubeflow#1633)

* Add Azure owners (kubeflow#1524)

* Create v1.1.0 Azure Kfdef manifests (kubeflow#1487)

* kfdef for azure

* kfdef for azure

* Axure kfdef

* argo version update

* Owners

* OWNERS

* argo version

* Tickle owners

* Tickle owners

* Create v1.1.0 Azure Kfdef manifests with OIDC Azure AD  (kubeflow#1576)

* Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml

* intial kdef

* indentation

* eof

* eof

* eof

* eof

* eof

* adding istio to azure stack

* indentation

* update URI

* Rename rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system-auth-delegator.yaml to rbac.authorization.k8s.io_v1_clusterrolebinding_custom-metrics:system:auth-delegator.yaml

* placeholder for azure ad  values

* Add overlay to support Azure Database for MySQL (kubeflow#1587)

* Add readme file

* Add Azure overlay for metadata

* Add azure overlay and readme file

* Changed the default metadata db name to be metadata-db

* Remove duplicated file

* Few edits when proofreading the readme.md

* Adding db name to be optional

* move the overlay to azure stack folder

* using relative path for metadata folder

* Add Azure kfdef 1.2 manifests

* Remove Tensorboard from Azure Stack

* Adding myself as Azure stack approver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ability to only generate parts of a component in the jsonnet file
6 participants