Webapp: Don't use DM for IAM. #1550
Conversation
|
/retest |
| } | ||
|
|
||
| func (s *ksServer)ApplyIamPolicy(ctx context.Context, req ApplyIamRequest) error { |
There was a problem hiding this comment.
Let's add retry into ApplyIamPolicy.
There's a small chance that concurrent iam change might occur for same project.
| }).Do() | ||
| retry = 0 | ||
| if retry < 5 { | ||
| _, err = resourceManager.Projects.SetIamPolicy( |
There was a problem hiding this comment.
If the failure is caused by concurrent iam policy change, we need to re-get the changed iam policy as refresh start and then apply configs to it and try to set iam again.
There was a problem hiding this comment.
I see, updated. Thanks
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunmingg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* fix * review * review
/cc @kunmingg
iam_bindings_template.yaml is the same as https://github.com/kubeflow/kubeflow/blob/master/scripts/gke/deployment_manager_configs/iam_bindings_template.yaml so it will be easy to merge later.
cc @jlewi
This change is