New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue 1050 - camelCase for some recently fixed params. #1556
Conversation
…m_schedulers, num_servers, num_workers, num_gpus and giturl.
/lgtm Would be great if you could do a quick check of the docs and see if they need to be updated. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jlewi I did a deep search within the repo and to best of my knowledge the only param that needed a doc/README.md update is If there are other places where we keep the docs, please let me know. |
@ashahba Thanks I was specifically referring to the docs on our website |
/ok-to-test |
Thanks @jlewi . Please let me know if that sounds reasonable 🙂 |
…low#1556) * camelCase for some recently fixed params, these include image_gpu, num_schedulers, num_servers, num_workers, num_gpus and giturl. * Style enhancements for pytorch-job.jsonnet
fixes #1050
First round of changes include updating
image_gpu, num_schedulers, num_servers, num_workers, num_gpus and giturl
in files:More is on the way but I need the get green light on this first before making the rest of changes that I mentioned in here: #1050 (comment)
Otherwise this should be sufficient for the release and I can file a separate issue and a subsequent PR to work on that after we are done with the release.
I'm open to either one, please let me know.
This change is