Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase pageSize for service list to avoid truncate #1558

Merged
merged 1 commit into from Sep 18, 2018

Conversation

kunmingg
Copy link
Contributor

@kunmingg kunmingg commented Sep 18, 2018

Default page size for enabled service list is 25.
Returned result will be truncated and incomplete if there are too many enabled services in a project.
Which confuses the caller.


This change is Reviewable

@kunmingg
Copy link
Contributor Author

/assign @lluunn
@abhi-g

@lluunn
Copy link
Contributor

lluunn commented Sep 18, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d8973b1 into kubeflow:master Sep 18, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants