Adding --skipInitProject to kfctl_test.jsonnet until CI quota is increased

[ashahba]

fixes #1562

---

This change is 

[ashahba]

@jlewi did we want this in?

[jlewi]

@ashahba Apologies for the delay. (I also recommend doing /assign if you want someone to review your PRs) that way it shows up in (https://k8s-gubernator.appspot.com/pr) as needing attention.

I'll take a look

[jlewi]

I think this is a good fix; even when quota fixes are resolved.

I'll open up an issue to properly test the uninitialized project case.

[jlewi]

/lgtm
/approve

[ashahba]

/assign @jlewi

[jlewi]

/ok-to-test

[jlewi]

@ashahba sent you an invite to the org so you can trigger the tests on your PRs.

[ashahba]

/retest

[ashahba]

/retest

[jlewi]

The presubmit failed.

Looks like there might be a bug in kfctl.s

+ echo CONFIG_FILE=cluster-kubeflow.yaml
+ '[' -z '' ']'
++ gcloud projects describe --skipInitProject '--format=value(project_number)'
ERROR: (gcloud.projects.describe) unrecognized arguments: --skipInitProject (did you mean '--project'?)
Usage: gcloud projects describe PROJECT_ID [optional flags]
 optional flags may be  --help
For detailed information on this command and its flags, run:
 gcloud projects describe --help

Looks like --skipInitProject is being added to the gcloud project describe command but it shouldn't be.

[jlewi]

/assign @kunmingg

@kunming can you take the lead on reviewing this PR? I'm a bit backed up.

[ashahba]

@kunmingg Jeremy is right, looks like we are passing irrelevant options to gcloud in kfctl.sh.
I was a bit busy last couple of days, I'll take a closer look to see where we mix up arguments.
But by all means feel free to provide your feedback.

[kunmingg]

line 160 and 161 should swap.

[ashahba]

Looks like we are still getting:

Command failed: /mnt/test-data-volume/kubeflow-presubmit-kfctl-1564-db10e7a-3535-baed/src/kubeflow/kubeflow/scripts/kfctl.sh init kfctl-b
aed --platform gcp --project kubeflow-ci --skipInitProject
command didn't succeed

🤔

[ashahba]

@kunmingg and @jlewi turned out the while loop was making an extra shift near line https://github.com/kubeflow/kubeflow/pull/1564/files#diff-8a6f2d237f052b07ca594c20830ed9d2L111
which ended up loosing some command line options.

But it's fixed now and this PR is ready for merge 🙂

[jlewi]

Thanks!
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jlewi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment