Final readme fixes #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
aronchick
reviewed
Dec 7, 2017
README.md
Outdated
| ## Components | ||
|
|
||
| ### JupyterHub | ||
| Refer to the README in the [tensorflow/k8s](https://github.com/tensorflow/k8s) repository for more information on using the TfJob controller to run TensorFlow jobs on K8s. |
There was a problem hiding this comment.
I'm not fond of sending people to another repo to read up on how to use. Can we keep the instructions inline?
There was a problem hiding this comment.
The instructions are a bit complex - @jlewi PTAL
There was a problem hiding this comment.
Added some sample config but retained pointer to more detailed docs. @aronchick PTAL.
jlewi
approved these changes
Dec 7, 2017
|
Merging. @vishh, if you have any concerns, please let me know. Will address in follow-up. |
kimwnasptd
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Mar 5, 2019
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Nov 1, 2019
VaishnaviHire
pushed a commit
to VaishnaviHire/kubeflow
that referenced
this pull request
May 19, 2022
[pull] master from kubeflow:master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vishh @aronchick @jlewi