Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the TFJob image to the latest image and tag 0.3 #1608

Merged
merged 1 commit into from Sep 24, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Sep 23, 2018


This change is Reviewable

@jlewi
Copy link
Contributor Author

jlewi commented Sep 23, 2018

/assign @richardsliu

1. Run the following command to apply the new image tag

```
releaseing/run_apply_image_tags.sh .*tf_operator.*:vX.Y.Z
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo - "releasing"

@richardsliu
Copy link
Contributor

Nit: In the future I think we should keep image updates from other changes in separate PRs. This makes it easier to revert if necessary.

@richardsliu
Copy link
Contributor

/lgtm
/approve

@jlewi
Copy link
Contributor Author

jlewi commented Sep 24, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi, richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlewi
Copy link
Contributor Author

jlewi commented Sep 24, 2018

deploy_argo test failed;
/test all

The pod logs for the test-argo-deploy step show

failed to get container status {"docker" "1f1b551a900a493f4f25efb0f889cc11e33d50b9081efb5e4f0c78330e4a7376"}: rpc error: code = Unknown desc = Error: No such container: 1f1b551a900a493f4f
25efb0f889cc11e33d50b9081efb5e4f0c78330e4a7376

* This makes the change on master
* Will need to cherry pick it onto the 0.3 branch afterwards.

* Related to kubeflow#1599
@richardsliu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 00d2921 into kubeflow:master Sep 24, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* This makes the change on master
* Will need to cherry pick it onto the 0.3 branch afterwards.

* Related to kubeflow#1599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants