Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow folks to have the kubeflow github repo over https + improve error message #1626

Merged
merged 2 commits into from Oct 14, 2018

Conversation

holdenk
Copy link
Contributor

@holdenk holdenk commented Sep 25, 2018

Allow folks to have the kubeflow github repo over https + improve error message -- we don't actually need testing.git for the remote


This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@holdenk
Copy link
Contributor Author

holdenk commented Sep 26, 2018

cc @pdmack since you're the one who told me about the auto-formatter :)

@googlebot
Copy link

CLAs look good, thanks!

@pdmack
Copy link
Member

pdmack commented Sep 26, 2018

/ok-to-test

@pdmack
Copy link
Member

pdmack commented Sep 27, 2018

/approve
/lgtm

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pdmack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@holdenk
Copy link
Contributor Author

holdenk commented Oct 3, 2018

/retest

@pdmack
Copy link
Member

pdmack commented Oct 3, 2018

Ironically, all.jsonnet needs formatting.

@holdenk
Copy link
Contributor Author

holdenk commented Oct 9, 2018

hahahah. Ok i'll reformat :)

@holdenk holdenk force-pushed the improve-jsonnet-format-experience branch from 908524d to 1275eb2 Compare October 10, 2018 14:37
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 10, 2018
@holdenk
Copy link
Contributor Author

holdenk commented Oct 10, 2018

Ran jsonnet format on all and it looks like it doesn't need any changes now, maybe master just was updated? /retest

@holdenk
Copy link
Contributor Author

holdenk commented Oct 11, 2018

I'm not sure I understand the workflow failures... /retest?

@holdenk
Copy link
Contributor Author

holdenk commented Oct 13, 2018

/retest

@k8s-ci-robot
Copy link
Contributor

@holdenk: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-presubmit 1275eb2 link /test kubeflow-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jlewi
Copy link
Contributor

jlewi commented Oct 14, 2018

Test failures should be unrelated to this PR. So I'll just merge this manually.

Thanks for the fix.

@jlewi jlewi merged commit 21b536d into kubeflow:master Oct 14, 2018
leoncamel pushed a commit to leoncamel/kubeflow that referenced this pull request Oct 14, 2018
…or message (kubeflow#1626)

* Allow folks to have the kubeflow github repo over https & clarify error message -- we don't actually need testing.git for the remote

* Only print non-matching repos if we fail to match.
@holdenk
Copy link
Contributor Author

holdenk commented Oct 17, 2018

Thanks @jlewi :)

saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
…or message (kubeflow#1626)

* Allow folks to have the kubeflow github repo over https & clarify error message -- we don't actually need testing.git for the remote

* Only print non-matching repos if we fail to match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants