New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow folks to have the kubeflow github repo over https + improve error message #1626
Allow folks to have the kubeflow github repo over https + improve error message #1626
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
cc @pdmack since you're the one who told me about the auto-formatter :) |
CLAs look good, thanks! |
/ok-to-test |
/approve Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pdmack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Ironically, all.jsonnet needs formatting. |
hahahah. Ok i'll reformat :) |
…or message -- we don't actually need testing.git for the remote
908524d
to
1275eb2
Compare
New changes are detected. LGTM label has been removed. |
Ran jsonnet format on all and it looks like it doesn't need any changes now, maybe master just was updated? /retest |
I'm not sure I understand the workflow failures... /retest? |
/retest |
@holdenk: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Test failures should be unrelated to this PR. So I'll just merge this manually. Thanks for the fix. |
…or message (kubeflow#1626) * Allow folks to have the kubeflow github repo over https & clarify error message -- we don't actually need testing.git for the remote * Only print non-matching repos if we fail to match.
Thanks @jlewi :) |
…or message (kubeflow#1626) * Allow folks to have the kubeflow github repo over https & clarify error message -- we don't actually need testing.git for the remote * Only print non-matching repos if we fail to match.
Allow folks to have the kubeflow github repo over https + improve error message -- we don't actually need testing.git for the remote
This change is