[Cherry-pick] Add a simple e2e-test for katib #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is run as part of kfctl e2e test
abhi-g
reviewed
Sep 27, 2018
| @@ -210,6 +210,7 @@ ksApply () { | |||
| ks apply default -c centraldashboard | |||
| ks apply default -c tf-job-operator | |||
| ks apply default -c argo | |||
| ks apply default -c katib | |||
There was a problem hiding this comment.
This would mean that katib will get deployed by default into the installations. Is that what we want?
There was a problem hiding this comment.
I am assuming that 0.3 onwards we want to install katib by default
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhi-g The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master PR #1638
Related to #1483
This is run as part of the kfctl e2e test after setting up the kubeflow on the gke cluster.
It uses kubectl to verify the various deployments made by katib ksonnet component.
/assign @jlewi
This change is