Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF Serving changes: enable http server, test cleanup etc #1647

Merged
merged 6 commits into from Sep 28, 2018

Conversation

lluunn
Copy link
Contributor

@lluunn lluunn commented Sep 27, 2018

  • add param for serviceType
  • enable TF Serving's http server by default. testing both http server and http proxy
  • move tf serving testing workflow from image releaser to where other workflows are
  • remove the part that's building images. we don't need this as Use tensorflow/serving images #1299
    (the new tfserving.libsonnet is copied from images/releaser/workflows.libsonnet, and remove building image part)

Fix #1258
Fix #896


This change is Reviewable

@lluunn lluunn changed the title WIP TF Serving changes: enable http server, test cleanup etc Sep 27, 2018
@lluunn
Copy link
Contributor Author

lluunn commented Sep 27, 2018

/assign @jlewi

@jlewi
Copy link
Contributor

jlewi commented Sep 28, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 975b66f into kubeflow:master Sep 28, 2018
k8s-ci-robot pushed a commit that referenced this pull request Oct 1, 2018
* move tf serving test workflow

* fix

* fix style

* fix

* add http

* fix port
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* move tf serving test workflow

* fix

* fix style

* fix

* add http

* fix port
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants