Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PVC to Katib #1687

Merged
merged 2 commits into from Oct 3, 2018
Merged

Add PVC to Katib #1687

merged 2 commits into from Oct 3, 2018

Conversation

inc0
Copy link

@inc0 inc0 commented Oct 1, 2018 •
edited by jlewi

Add persistency to Katib database in ksonnet prototye

This change is Reviewable

@swiftdiaries
Copy link
Member

/lgtm
/approve

@swiftdiaries
Copy link
Member

@inc0 ERROR : /mnt/test-data-volume/kubeflow-presubmit-unittests-1687-c606bc2-3637-2799/src/kubeflow/kubeflow/kubeflow/katib/vizier.libsonnet is not formatted

@inc0
Copy link
Author

inc0 commented Oct 1, 2018 •
edited

/assign @jlewi @YujiOshima

@k8s-ci-robot k8s-ci-robot added size/M and removed size/L labels Oct 1, 2018
@inc0
Copy link
Author

inc0 commented Oct 2, 2018

/retest

@jlewi
Copy link
Contributor

jlewi commented Oct 3, 2018

/assign @jlewi
It looks like the most recent failure was a flake building the notebook images. I wouldn't have expected that to be triggered.

@jlewi
Copy link
Contributor

jlewi commented Oct 3, 2018

/test all
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi, swiftdiaries

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlewi jlewi mentioned this pull request Oct 3, 2018
Closed
@inc0 inc0 mentioned this pull request Oct 3, 2018
Merged
@inc0
Add PVC to Katib
97057a7 
Add persistency to Katib database in ksonnet prototye
@inc0
fix database pvc
609c969
@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 3, 2018
@jlewi
Copy link
Contributor

jlewi commented Oct 3, 2018

/lgtm

@jlewi
Copy link
Contributor

jlewi commented Oct 3, 2018

Not sure why CLA check is stuck. Lets try reopening the PR.

@jlewi jlewi closed this Oct 3, 2018
@jlewi jlewi reopened this Oct 3, 2018
@inc0
Copy link
Author

inc0 commented Oct 3, 2018

Maybe something to do with me leaving Intel? I still have individual CLA tho...

@k8s-ci-robot k8s-ci-robot merged commit b84517f into kubeflow:master Oct 3, 2018
richardsliu pushed a commit that referenced this pull request Oct 4, 2018
@richardsliu
Add PVC to Katib (#1687)
fbd88d1 
* Add PVC to Katib

Add persistency to Katib database in ksonnet prototye

* fix database pvc
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@k8s-ci-robot
Add PVC to Katib (kubeflow#1687)
171e7b9 
* Add PVC to Katib

Add persistency to Katib database in ksonnet prototye

* fix database pvc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardsliu richardsliu Awaiting requested review from richardsliu

@swiftdiaries swiftdiaries Awaiting requested review from swiftdiaries

Assignees

@jlewi jlewi

@swiftdiaries swiftdiaries

Labels
approved area/0.3.1 cla: yes lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@inc0 @swiftdiaries @jlewi @k8s-ci-robot @googlebot