*: Add CRD creation for TFJob #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaocegege
force-pushed
the
crd
branch
2 times, most recently
from
0b51ee0
to
4cf061e
Compare
gaocegege
changed the title
jlewi
reviewed
Jan 30, 2018
| @@ -111,6 +111,19 @@ roleRef: | |||
| name: tf-job-operator | |||
|
|
|||
|
|
|||
| --- | |||
There was a problem hiding this comment.
Lets just delete deploy_crd.yaml rather than trying to keep it up to date.
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
|
@jlewi Thanks for your review, I have rebased and PTAL again. |
jlewi
approved these changes
Jan 30, 2018
|
/test all |
|
Can you explain the ":*" in the PR title? |
|
It's a commit convension in coala community, which means the PR changes lots of code in different components. And the second commit |
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Nov 1, 2019
* remove unused variable viewer-clusterDomain from pipeline/pipelines-viewer/base/kustomization.yaml, regenerate tests * add namespace to kustomization.yaml * update unit-tests
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Feb 15, 2021
* add mutex to studyjob controller Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com> * use sync.Map Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com> * update only when the instance was changed Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
elenzio9
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #164 , ref kubeflow/training-operator#281
Blocked by #169