Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

components: tf-notebook-image: pin to base image #1784

Merged
merged 2 commits into from Oct 26, 2018

Conversation

r2d4
Copy link
Member

@r2d4 r2d4 commented Oct 15, 2018

You can reference images by digest in the FROM or docker pull commands.

https://docs.docker.com/engine/reference/commandline/pull/#pull-an-image-by-digest-immutable-identifier

The tag is ignored, but you can keep it there to give more context.


This change is Reviewable

@r2d4
Copy link
Member Author

r2d4 commented Oct 15, 2018

/test kubeflow-presubmit

@r2d4
Copy link
Member Author

r2d4 commented Oct 16, 2018

/hold

@r2d4
Copy link
Member Author

r2d4 commented Oct 26, 2018

/hold cancel

@r2d4
Copy link
Member Author

r2d4 commented Oct 26, 2018

/assign @richardsliu

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b9014c7 into kubeflow:master Oct 26, 2018
@r2d4 r2d4 deleted the pin-to-ubuntu-image branch October 26, 2018 22:20
rogaha pushed a commit to rogaha/kubeflow that referenced this pull request Nov 20, 2018
* components: tf-notebook-image: pin to base image

* typo
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* components: tf-notebook-image: pin to base image

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants