Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RapidsAI notebook image #1809

Merged
merged 1 commit into from Oct 24, 2018
Merged

Add RapidsAI notebook image #1809

merged 1 commit into from Oct 24, 2018

Conversation

pdmack
Copy link
Member

@pdmack pdmack commented Oct 17, 2018 •
edited by jlewi

Related to #1806

Couldn't find their public Dockerfile repo.

/assign @jlewi

This change is Reviewable

@jlewi
Copy link
Contributor

jlewi commented Oct 17, 2018

That was quick!

@jlewi
Copy link
Contributor

jlewi commented Oct 17, 2018

/hold
/lgtm
/approve

Do you want to add it to our image build workflow so that we can build it in pre & postsubmits? Just cancel the hold if you think we should do it in a follow on PR.

@pdmack
Copy link
Member Author

pdmack commented Oct 17, 2018

That was quick!

Would you say it was...rapid?

@pdmack
Copy link
Member Author

pdmack commented Oct 17, 2018 •
edited

ImportError: JupyterHub single-user server requires notebook >= 4.0
Looks like it needs fixin'

Also it installs the jupyter user...hmmm.

@pdmack pdmack changed the title Add RapidsAI notebook image [WIP] Add RapidsAI notebook image Oct 17, 2018
@ddutta
Copy link
Member

ddutta commented Oct 17, 2018 via email

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 22, 2018
@pdmack pdmack changed the title [WIP] Add RapidsAI notebook image Add RapidsAI notebook image Oct 22, 2018
@pdmack
Copy link
Member Author

pdmack commented Oct 22, 2018 •
edited

Maybe a real Scientist of Data could try out gcr.io/kubeflow-dev/kubeflow-rapidsai-notebook:latest?

I just smoke tested with imports of pygdf, numpy, pandas, etc.

They have some notebooks in /rapids/notebooks but they require GPU obvs.

@jlewi
Copy link
Contributor

jlewi commented Oct 23, 2018

@pdmack You're welcome to use the cluster in kubeflow-dev to try out with GPUs. I think you need a P100 not a K80 to try things.

@jlewi
Copy link
Contributor

jlewi commented Oct 23, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 23, 2018
@pdmack
Copy link
Member Author

pdmack commented Oct 24, 2018

/hold cancel

@jlewi
Copy link
Contributor

jlewi commented Oct 24, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4f8c0b1 into kubeflow:master Oct 24, 2018
@pdmack pdmack mentioned this pull request Nov 27, 2018
Merged
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@k8s-ci-robot
Add RapidsAI notebook image (kubeflow#1809)
9640323
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
@davidspek
Dex: Fix user must be valid email address (kubeflow#1809)
c5cb42f 
* Fix user must be valig email address

* Make suggested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi Awaiting requested review from jlewi

@kunmingg kunmingg Awaiting requested review from kunmingg

Assignees

@jlewi jlewi

Labels
approved cla: yes lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pdmack @jlewi @ddutta @k8s-ci-robot @googlebot