Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tensorflow-notebook-image dockerfiles #182

Merged
merged 1 commit into from Feb 1, 2018
Merged

Add tensorflow-notebook-image dockerfiles #182

merged 1 commit into from Feb 1, 2018

Conversation

dogopupper
Copy link
Contributor

@dogopupper dogopupper commented Feb 1, 2018 •
edited by jlewi

As described in the issue #126

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@k8s-ci-robot
Copy link
Contributor

Hi @dogopupper. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dogopupper dogopupper mentioned this pull request Feb 1, 2018
Closed
@dogopupper
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@jlewi jlewi merged commit 06e307a into kubeflow:master Feb 1, 2018
@jlewi
Copy link
Contributor

jlewi commented Feb 1, 2018

Thank you for the contibution!

@dogopupper
Copy link
Contributor Author

Happy to help ^^

yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Nov 1, 2019
@k8s-ci-robot
add centraldashboard application (kubeflow#182)
849f28c
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
@terrytangyuan @k8s-ci-robot
Add teams for xgboost-operator, mpi-operator, and kubeflow/common (ku…
3e1bf0d 
…beflow#182)

* Add teams for xgboost-operator, mpi-operator, and kubeflow/common

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>

* Additional members

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi jlewi approved these changes

Assignees
No one assigned
Labels
needs-ok-to-test size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dogopupper @googlebot @k8s-ci-robot @jlewi