fixes 'metacontroller's compositecontrollers and decoratorcontrollers need to be at Cluster scope' #1834
Conversation
… need to be at Cluster scope'
|
/assign @jlewi |
|
So metacontroller is a cluster scoped resource? It looks like this PR is installing metacontroller by default. Do we already have a component that depends on metacontroller or is this in preparation for the new Jupyter CRD? |
|
So metacontroller is cluster scoped? It looks like you are installing metacontroller by default now with kfctl.sh. Do we already have something that is using metacontroller by default? Or is this in preparation for the Jupyter CRD. |
|
Yes, metacontroller in 0.2 is cluster scoped. We could wait until jupyter CRD is ready. Also we need to upgrade cloud-endpoints. |
|
Since this is in preparation for jupyterhub replacement which i'll open a PR this week and it doesn't conflict with cloud-endpoints (which isn't using any of metacontroller's 0.2 crds), I think this could go in now. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… need to be at Cluster scope' (kubeflow#1834) * fixes 'metacontroller's compositecontrollers and decoratorcontrollers need to be at Cluster scope' * add metacontroller to kfctl * /retest
fixes #1833
This change is