New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
part of fix for 'add jsonnet tests for all libsonnet files' #1835
Conversation
/assign @jlewi |
/cc @ashahba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @kkasravi for updating the test cases. |
@@ -3,7 +3,7 @@ | |||
// @description Ambassador Component | |||
// @shortDescription Ambassador | |||
// @param name string Name | |||
// @optionalParam cloud string null Cloud | |||
// @optionalParam platform string none supported platforms {none|gke|minikube} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was @ashahba 's PR already submitted? Why change "null" to "none"? Is that to match what kfctl does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashahba's PR missed optionalParam. Yes - changed to 'none' for kfctl.
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashahba, jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#1835) * part of fix for 'add jsonnet tests for all libsonnet files' * /retest
part of fix for #1542
This change is