New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make alert metrics count type & add service heartbeat #1849
Conversation
/assign @jlewi |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhi-g The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -1137,5 +1165,6 @@ func (s *ksServer) StartHttp(port int) { | |||
// add an http handler for prometheus metrics | |||
http.Handle("/metrics", promhttp.Handler()) | |||
|
|||
go countHeartbeat() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you could probably inline this one as
go func() {
time.Sleep(10 * time.Second)
serviceHeartbeat.Inc()
}()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, added the labels too soon...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works the same either way :)
* siwtch alert metrics to count type; add service heartbeat signal * rename vars
* siwtch alert metrics to count type; add service heartbeat signal * rename vars
This change is