Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make prober always sleep before execute #1908

Merged
merged 2 commits into from Nov 20, 2018
Merged

make prober always sleep before execute #1908

merged 2 commits into from Nov 20, 2018

Conversation

kunmingg
Copy link
Contributor

@kunmingg kunmingg commented Nov 5, 2018 •
edited by jlewi

  1. make prober always sleep before execute
  2. catch kubectl create exception when it happens

This change is Reviewable

@kunmingg
Copy link
Contributor Author

kunmingg commented Nov 6, 2018

/assign @jlewi
/assign @r2d4

jlewi
jlewi reviewed Nov 7, 2018
View reviewed changes
testing/test_deploy_app.py
(args.deployment, args.zone, args.project)).split(' '))
util_run(("kubectl create -f %s" % SSL_DIR).split(' '))

return True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use the retrying module rather than writing our own loop for retries?
The retrying module allows you to specify various conditions. Typically, I suggest retrying for up to some maximum amount of time with exponential backoff between retries.

Typically its best to specify a max duration for retries e.g. we will give up after X minutes; because that makes it easier to reason about.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@kunmingg
Copy link
Contributor Author

/retest

@jlewi
Copy link
Contributor

jlewi commented Nov 20, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kunmingg
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0fad071 into kubeflow:master Nov 20, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@kunmingg @k8s-ci-robot
make prober always sleep before execute (kubeflow#1908)
f33732d 
* make prober always sleep before execute

* use retry modules
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
@yanniszark
Upgrade Istio to 1.9.5 (kubeflow#1908)
c3f9e39 
* common: Upgrade to Istio 1.9.5

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* common: Fix all references to new Istio 1.9.5

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi jlewi left review comments

@abhi-g abhi-g Awaiting requested review from abhi-g

@lluunn lluunn Awaiting requested review from lluunn

Assignees

@jlewi jlewi

@r2d4 r2d4

Labels
approved cla: yes lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kunmingg @jlewi @k8s-ci-robot @r2d4 @googlebot