Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ksonnet package path for tf-job-operator #1920

Merged
merged 5 commits into from Nov 8, 2018

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Nov 6, 2018

Fixes #1885
I Moved tf-job-operator component from kubeflow/core to kubeflow/tf-job-operator.


This change is Reviewable

@andreyvelich
Copy link
Member Author

/assign @jlewi

@jlewi
Copy link
Contributor

jlewi commented Nov 6, 2018

/assign @richardsliu

What do you think we should call the package? "tf-job-operator" just "tf-job"?

@jlewi
Copy link
Contributor

jlewi commented Nov 6, 2018

It looks like we use "pytorch-job" so I think "tf-job" would be consistent.

@richardsliu
Copy link
Contributor

Would "tf-job" be confusing since it is also the name of the custom resource?

I would prefer something like "tf-training".

@andreyvelich
Copy link
Member Author

@richardsliu @jlewi
I changed package name to tf-training and kept prototype name to tf-job-operator.
We can install and generate this component like this:

ks pkg install kubeflow/tf-training
ks generate tf-job-operator tf-job-operator

@richardsliu
Copy link
Contributor

@andreyvelich Looks like the minikube e2e test failed:

INFO|2018-11-07T09:44:10|util.py:41| Running: ks generate tf-job-operator tf-job-operator
cwd=/mnt/test-data-volume/kubeflow-presubmit-kubeflow-e2e-minikube-1920-34fe7c8-4250-117d/kubeflow-test-3657
INFO|2018-11-07T09:44:10|util.py:56| Subprocess output:
INFO|2018-11-07T09:44:10|util.py:62| level=error msg="no prototype names matched 'tf-job-operator'"
ERROR|2018-11-07T09:44:11|test_helper.py:101| Subprocess failed;
level=error msg="no prototype names matched 'tf-job-operator'"
Traceback (most recent call last):
 File "/mnt/test-data-volume/kubeflow-presubmit-kubeflow-e2e-minikube-1920-34fe7c8-4250-117d/src/kubeflow/testing/py/kubeflow/testing/test_helper.py", line 99, in wrap_test
   test_case.test_func(test_case)
 File "/mnt/test-data-volume/kubeflow-presubmit-kubeflow-e2e-minikube-1920-34fe7c8-4250-117d/src/kubeflow/kubeflow/testing/deploy_kubeflow.py", line 63, in deploy_kubeflow
   cwd=app_dir)
 File "/mnt/test-data-volume/kubeflow-presubmit-kubeflow-e2e-minikube-1920-34fe7c8-4250-117d/src/kubeflow/testing/py/kubeflow/testing/util.py", line 74, in run
   " ".join(command), process.returncode), "\n".join(output))
CalledProcessError: Command 'cmd: ks generate tf-job-operator tf-job-operator exited with code 1' returned non-zero exit status 1

@andreyvelich
Copy link
Member Author

@richardsliu I fixed it.

@richardsliu
Copy link
Contributor

Thanks for fixing this.
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 78d5aa0 into kubeflow:master Nov 8, 2018
rogaha pushed a commit to rogaha/kubeflow that referenced this pull request Nov 20, 2018
* Change path to tf-job-operator component

* Add newline to parts

* Change package name to tf-training

* Add tf-training package to testing files
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* Change path to tf-job-operator component

* Add newline to parts

* Change package name to tf-training

* Add tf-training package to testing files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants