New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ksonnet package path for tf-job-operator #1920
Conversation
/assign @jlewi |
/assign @richardsliu What do you think we should call the package? "tf-job-operator" just "tf-job"? |
It looks like we use "pytorch-job" so I think "tf-job" would be consistent. |
Would "tf-job" be confusing since it is also the name of the custom resource? I would prefer something like "tf-training". |
@richardsliu @jlewi
|
@andreyvelich Looks like the minikube e2e test failed:
|
@richardsliu I fixed it. |
Thanks for fixing this. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardsliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Change path to tf-job-operator component * Add newline to parts * Change package name to tf-training * Add tf-training package to testing files
* Change path to tf-job-operator component * Add newline to parts * Change package name to tf-training * Add tf-training package to testing files
Fixes #1885
I Moved tf-job-operator component from kubeflow/core to kubeflow/tf-job-operator.
This change is