make IAP optional for click-deploy app #1927
Conversation
| </ul> | ||
| <ul> | ||
| <ul> | ||
| <li> Click IAP Access (might need to wait up to 20 minutes on network settings) </li> |
There was a problem hiding this comment.
"20 minutes for domain and IAP to be setup"
| </ul> | ||
| <ul> | ||
| <ul> | ||
| <li> Click Cloud Shell; run command in pop up window; kubeflow UI will be at |
There was a problem hiding this comment.
Can you clarify these instructions? Where do users "click Cloud Shell"? Can we provide a link to launch it?
What command are they supposed to run in Cloud Shell?
There was a problem hiding this comment.
We provide button on UI and prepare script in user's source repo,
when user click button, cloud shell will clone repo and cd into script dir.
User only need to run ./conn.sh
| @@ -262,12 +271,53 @@ export default class DeployForm extends React.Component<any, DeployFormState> { | |||
| if (p.name === 'acmeEmail') { | |||
| p.value = email; | |||
| } | |||
| }); | |||
|
|
|||
| if (p.name === 'jupyterHubAuthenticator') { | |||
There was a problem hiding this comment.
So the client side JS is responsible for setting the authenticator for JupyterHub?
There was a problem hiding this comment.
Ideally not, will take care in #1971
|
This is great; just a minor comment about the instructions. |
|
Is it possible to add a checkbox for IAP setup, which is unchecked by default. When unchecked the IAP related fields can be hidden from the form, and visible if checked. |
kunmingg
force-pushed
the
connect
branch
2 times, most recently
from
7c5b7de
to
c2a9076
Compare
|
/lgtm but looks like this is now out of sync and needs to be updated. |
|
@jlewi |
|
@kunmingg Yes; I think using Auth Ambassador service with basic http auth is probably a better option. I still think we should probably go forward with this PR so that users can avoid enabling IAP and just use kubectl port-forward. WDYT? |
|
I agree with Jeremy that we can still merge this PR, allowing users the
option to use kubectl port-forward.
…On Fri, Nov 16, 2018 at 1:26 PM Jeremy Lewi ***@***.***> wrote:
@kunmingg <https://github.com/kunmingg> Yes; I think using Auth
Ambassador service with basic http auth is probably a better option.
I still think we should probably go forward with this PR so that users can
avoid enabling IAP and just use kubectl port-forward. WDYT?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1927 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALOqZnujihWmtXK7fKfJfv3uBby_nWNGks5uvy1-gaJpZM4YUFLe>
.
|
|
Sure, seems we might be able to automate cloud shell. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* make IAP optional for click-deploy app * more * automate cloud shell * frontend edit following review feedbacks * add input check when user choose to setup IAP
Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>
This change is