Redirect deployer webapp page to Kubeflow dashboard after its ready #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test kubeflow-presubmit |
jlewi
reviewed
Nov 12, 2018
|
This is great. |
|
/lgtm /hold |
kunmingg
reviewed
Nov 12, 2018
kunmingg
reviewed
Nov 12, 2018
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi, kunmingg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
rogaha
pushed a commit
to rogaha/kubeflow
that referenced
this pull request
Nov 20, 2018
…ubeflow#1945) * Wait for dashboard to get ready and redirect * Fixed javascript compilation issues * Fixed CORS issue with redirection using a hack for image fetching * add comment to explain reliance on JupyterHub logo * Formatting fix * Added a comment explaining CORS bypass * Added waiting message for dashboard redirect. * Add a 10s wait between retries
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
…ubeflow#1945) * Wait for dashboard to get ready and redirect * Fixed javascript compilation issues * Fixed CORS issue with redirection using a hack for image fetching * add comment to explain reliance on JupyterHub logo * Formatting fix * Added a comment explaining CORS bypass * Added waiting message for dashboard redirect. * Add a 10s wait between retries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1420
Fetching a GET on the dashboard URI which belongs in a different domain from the deployer in general gets prevented by the browser due to CORS prevention. This fix gets around that issue by leveraging the fact that a static image fetch hosted at the other dashboard site would not be prevented by the browser. Once that image is able to load within the deployer, it can redirect the user to the dashboard.
This change is